-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/sc 28761/super about fit and finish page title #2135
Merged
yitzhakc
merged 16 commits into
master
from
chore/sc-28761/super-about-fit-and-finish-page-title
Jan 26, 2025
Merged
Chore/sc 28761/super about fit and finish page title #2135
yitzhakc
merged 16 commits into
master
from
chore/sc-28761/super-about-fit-and-finish-page-title
Jan 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitzhakc
requested changes
Dec 15, 2024
…g css display none unnecessary
YishaiGlasner
previously approved these changes
Jan 20, 2025
yitzhakc
requested changes
Jan 21, 2025
YishaiGlasner
previously approved these changes
Jan 21, 2025
yitzhakc
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move position of title for all super about pages.
Code Changes
Notes
Perhaps the mobileAboutHeader should be re-named to aboutHeader since it now shows both on mobile and desktop. What do you think?